Code refactoring: Simplify MockDeploymentBackend #5056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
changed the title
noliveleger
changed the title
This was referenced Aug 8, 2024
noliveleger
force-pushed
the
kobocat-django-app-part-2-refactor-mock-deployment-backend
branch
from
0da213d
to
f68c59b
Compare
noliveleger
force-pushed
the
kobocat-django-app-part-2-refactor-mock-deployment-backend
branch
from
f68c59b
to
be7505e
Compare
noliveleger
changed the base branch from
kobocat-django-app-part-2
to
kobocat-django-app-part-2-remove-service-account
1 similar comment
…kobocat-django-app-part-2-refactor-mock-deployment-backend
jnm
requested changes
Sep 20, 2024
noliveleger
force-pushed
the
kobocat-django-app-part-2-remove-service-account
branch
from
59a00a6
to
41c6b73
Compare
jnm
merged commit 78ee7d8
into
kobocat-django-app-part-2-remove-service-account
4 checks passed
jnm
deleted the
kobocat-django-app-part-2-refactor-mock-deployment-backend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part VII of #5036.
Notes
Remove (almost) every mocked object, function, class etc... from
MockDeploymentBackend.All tests are using the same deployment mechanism than production which gives us a better test coverage.
The counterpart, it takes longer to run the whole suite without any parallel mechanism (such as
py-xdistplugin).Related issues
Part of #5036