Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring for project deployment #5036

Open
wants to merge 216 commits into
base: release/2.024.36
Choose a base branch
from

Conversation

noliveleger
Copy link
Contributor

@noliveleger noliveleger commented Jul 30, 2024

Description

This PR is for devs interest only. It should simplify the way projects are deployed and how KPI interacts with KoboCAT.

Notes

Since KoboCAT is part of KPI code base in openrosa django app, KobocatDeploymentBackend, shadow models are not needed anymore. The goal of this PR is to regroup many other small PRs which make a part of refactoring (i.e. to avoid a big PR to review).

Related issues

@noliveleger noliveleger changed the base branch from main to beta July 30, 2024 16:14
@noliveleger noliveleger changed the title Kobocat django app part 2 Code refactoring for project deployment Jul 30, 2024
jamesrkiger and others added 30 commits September 24, 2024 09:01
…-values

Replace default values with (invalid) placeholders
 # Conflicts:
 #	kobo/apps/openrosa/apps/logger/models/attachment.py
 #	kobo/apps/project_ownership/tests/api/v2/test_api.py
 #	kpi/deployment_backends/kc_access/utils.py
…efactor-mock-deployment-backend

Code refactoring: Simplify MockDeploymentBackend
…kobocat-django-app-part-2-handle-missing-xform
…bocat-django-app-part-2-better-error-handling
…andle-missing-xform

Code refactoring: Improve error message when XForm does not exist
…etter-error-handling

Code refactoring:  Better error handling in new deployment back-end class
…emove-service-account

Code refactoring: Remove `kobo_service_account` dependency
 # Conflicts:
 #	kobo/apps/stripe/tests/test_organization_usage.py
 #	kobo/apps/subsequences/tests/test_submission_stream.py
 #	kpi/tests/api/v2/test_api_submissions.py
 #	kpi/views/v2/data.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants