[TASK-1059] Handle submission groups in Access Log UI #5115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of canceling if another one failed
Here's the error we were encountering when running mocha-chrome
on Node >=17:
```
Promise Rejection: Error: connect ECONNREFUSED ::1:39193
at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1606:16) {
errno: -111,
code: 'ECONNREFUSED',
syscall: 'connect',
address: '::1',
port: 39193
}
```
Here's the patch that fixes this for us:
// node_modules/mocha-chrome/lib/client.js
- const client = await CDP({ port: instance.port });
+ const client = await CDP({ port: instance.port, host: '127.0.0.1' });
An alternative patch that would also succeed:
// node_modules/chrome-remote-interface/lib/defaults.js
- module.exports.HOST = 'localhost';
+ module.exports.HOST = '127.0.0.1';
Another option:
// node_modules/chrome-remote-interface/lib/external-request.js
- const {address} = await util.promisify(dns.lookup)(options.host);
+ const {address} = await util.promisify(dns.lookup)(
+ options.host,
+ {family:'IPv4'},
+ );
Thank you @nsainaney for writing this comment in nodejs/node#40702 [^1]:
> It appears to be a breaking change with how DNS.lookup works. With
> node 16, the lookup would return a IPv4 address but with node 17, it
> returns an IPv6 address which will break most REST clients that
> hardcode URLS like http://localhost:4040/api if the upstream server
> only binds to the IPv4 address (e.g. server.listen('127.0.0.1'…) etc…
[^1]: nodejs/node#40702 (comment)
Before committing to the 'patch' strategy, I checked to see if either
mocha-chrome or chrome-remote-interface had been updated later with this
workaround.
- chrome-remote-interface accepts a parameter for host, so nope.
Makes sense, since you can specify the host manually.
- mocha-chrome doesn't parameterize host, and the author of mocha-chrome
considers it an obsolete package and is no longer updating it.
and update all the instances <3
…gation is more consistent/secure also adds some useful comments
# Conflicts: # jsapp/js/projects/projectsTable/projectQuickActions.tsx # jsapp/scss/libs/react-tagsinput.scss
…into kobocat-django-app-part-2-remove-service-account
# Conflicts: # jsapp/js/account/security/email/emailSection.component.tsx # jsapp/scss/libs/react-tagsinput.scss
…emove-imports Code refactoring - Replace shadow models imports with their openrosa app counterparts
fix thumbnail resizing with FileSystemStorage
Fix 500 error when submitting data after changing the password
…t-uniqueness (backport) Fix 500 error when submitting data after changing the password
…rmdisclaimer Fix bad performance introduced in `2.024.25`
…ject-button-text [ TASK-1027 ] Conditional label for 'Delete Project and Data' button
…hments-tests Skip temporarily some failing tests
Also update few `angle-*` icons
…e it together with UniversalTable
…e the same consistent DRY CSS module as other security sections
|
Closed in favor of #5116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Describe the outcome of your work here. A non-programmer who is familiar with KoboToolbox should be able to understand what you've written; more technical details can be added to the Notes section below. You may omit this if the title alone provides enough information. Both the title and this description will be published in the release notes on our forum.
Notes
Describe what you've changed and why. This should allow the reviewer to understand more easily the scope of the PR. It's good to be thorough here.
Related issues
Build atop #5094 (
TASK-869-group-submissions-better) and #5109 (task857-access-log-ui)