Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix django-import-export dependencies #5148

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

jnm
Copy link
Member

@jnm jnm commented Oct 3, 2024

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Run ./python-format.sh to make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

For developers: fixes "ModuleNotFoundError: No module named 'tablib'" error that would occur when attempting to install Python dependencies for development.

Notes

Add subdependencies that were missing from #4986, presumably as a result of manually editing *requirements.txt files instead of running pip-compile.sh. The incomplete requirements files did not cause a problem with an initial pip-sync call, which allowed the subdependencies like tablib to remain, but future calls to pip-sync removed these subdependencies since they were missing from the *requirements.txt files. Internal discussion: https://chat.kobotoolbox.org/#narrow/stream/4-Kobo-Dev/topic/KPI.3A.20ModuleNotFoundError.3A.20No.20module.20named.20'tablib'

Related issues

Related to #4986

Add subdependencies that were missing from #4986, presumably as a result
of manually editing `*requirements.txt` files instead of running `pip-compile.sh`
@jnm jnm requested a review from Akuukis October 3, 2024 17:19
Copy link
Contributor

@Akuukis Akuukis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, repro:

  1. ➡️ in a fresh kobo-install run ./run.py (FYI kpi main branch is at 2c0159859)
  2. 🔴 notice a failing kpi container due missing tablib dependency
  3. ➡️ in kpi git checkout this PR
  4. ➡️ in kobo-install run ./run.py -cf build kpi --no-cache --force-rm
  5. ➡️ in kobo-install run ./run.py
  6. 🟢 notice a working kpi container

@Akuukis Akuukis merged commit 3d51e1a into main Oct 4, 2024
8 checks passed
@Akuukis Akuukis deleted the fix-django-import-export-dependencies branch October 4, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants