Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pyxform version with support for background-geopoint questions #5195

Closed

Conversation

RuthShryock
Copy link
Member

@RuthShryock RuthShryock commented Oct 24, 2024

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Run ./python-format.sh to make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes
  8. Create a testing plan for the reviewer and add it to the Testing section

Description

Support forms withbackground-geopointquestions which save background GPS location in surveys.

Notes

⚠️ This should NOT be reviewed until #5126 is merged.

Kpi is updated to support version 2.1.1 of pyxform. This version does not include recent support for background-geopoint questions so we are backporting this work into 2.1.1.

Also note that this pr has a small fix for a missing notify import in the formbuilder.

Testing

  1. Reinstall dev_requirements.txt in your shell.
  2. Upload an XLS form with a background-geopoint question. (Simple_background_geo.xlsx)
  3. Create and deploy the project.
  4. Download the XML and verify it has translated the form correctly. See example here.

@RuthShryock RuthShryock requested a review from jnm October 24, 2024 18:35
@RuthShryock RuthShryock marked this pull request as ready for review October 24, 2024 18:36
Base automatically changed from update-pyxform-version to main November 6, 2024 17:30
@jnm jnm force-pushed the backport-background-geopoint-question-to-pyxform branch from 9b1b11d to 72e535f Compare November 7, 2024 05:01
@jnm jnm changed the title Pin pyxform version with backported support for background-geopoint questions Pin pyxform version with support for background-geopoint questions Nov 7, 2024
@jnm
Copy link
Member

jnm commented Nov 7, 2024

After looking at this and the changes in pyxform v2.2.0, let's upgrade directly to that release. It'll make our lives easier in the future

@jnm jnm closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants