Preserve string IDs #119
Merged
Preserve string IDs #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garbear
force-pushed
the
preserve-strings
branch
from
43c61d0 to
66178f1
Compare
|
Got an ack from @gade01 on slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when a string in the middle of the settings changed, all subsequent strings would get new IDs, wreaking havoc on weblate.
Now, string IDs are preserved, and new strings are added to the end of strings.po.
How has this been tested?
Tested with UAE, see success: kodi-game/game.libretro.uae@testing
Another success with vice_x64: kodi-game/game.libretro.vice_x64@70a16dc