Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration errors introduced in 0.9 and later. #54

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Fix integration errors introduced in 0.9 and later. #54

merged 1 commit into from
Apr 3, 2024

Conversation

P-Storm
Copy link
Contributor

@P-Storm P-Storm commented Mar 25, 2024

Should fix (at least partial) #50 .

  • Manual linting
  • Fixed min_version error, by undefined variable.

@P-Storm
Manual linting
5b74a94 
Fixed min_version error, by undefined variable.
@P-Storm
Copy link
Contributor Author

P-Storm commented Mar 25, 2024

I would suggest to introduce a patch level stepping.

@P-Storm P-Storm mentioned this pull request Mar 26, 2024
Closed
koenhendriks
koenhendriks approved these changes Apr 3, 2024
View reviewed changes
Copy link
Owner

@koenhendriks koenhendriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just going to blindly merge this as the current version is broken and I don't have much time now 🙃

@koenhendriks koenhendriks merged commit ab43b21 into koenhendriks:main Apr 3, 2024
1 of 2 checks passed
@koenhendriks koenhendriks linked an issue Apr 4, 2024 that may be closed by this pull request
Integration does not work after upgrade to 0.9 #50
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koenhendriks koenhendriks koenhendriks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration does not work after upgrade to 0.9
2 participants
@P-Storm @koenhendriks