Add long press and release event support #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds long press support and basic for release event support. This is done by overriding @Final methods of homeassistant's button for which it is unclear why they are marked as such. Attributes for type of click are now set to "long" for a long press and "single" for a short press.
This reverts commit fd10e3a.
P-Storm
reviewed
Apr 12, 2024
|
Otherwise, looking good. Also nice that you grouped the topics to one space 👍 |
P-Storm
approved these changes
Apr 12, 2024
koenhendriks
requested changes
Apr 13, 2024
There was a problem hiding this comment.
Could you take a look at the CI errors?
Error: R] [SERVICES] Service long_press has no name and is not in the translations file
Error: R] [SERVICES] Service release has no name and is not in the translations file
Error: R] [TRANSLATIONS] Invalid strings.json: extra keys not allowed @ data['config']['services']. Got {'long_press': {'name': 'Long press', 'description': 'Long press on a button on button+'}, 'release': {'name': 'Release', 'description': 'Release of a button on button+'}}
required key not provided @ data['config']['step']. Got None
|
Done |
|
ping @koenhendriks :-) |
koenhendriks
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds long press support and basic for release event support. This is done by overriding @Final
methods of homeassistant's button for which it is
unclear why they are marked as such.
Attributes for type of click are now set to "long" for a long press and "single" for a short press.