Implement Button+ V1.12 API and introduce compatibility layer

[scspijker]

I've started to implement the V1.12 API and introducing a compatibility layer so it's easier to implement new versions.

For now this is a draft PR, so other maintainers can track progress and send early feedback.

So far I've:

• Introduced Firmware version based model detection
• Introduced unit tests for parsing JSON responses
• Introduced a Docker Compose script for easy testing of the integration
• Introduced V1.12 JSON parsing
• Implemented the new interface model in the domain layer 🔨

Thanks, and let me know if something could be better! This is my first Python code / contribution ever 💪

[scspijker]

So, it's completely working now on v1.12.2. But Firmware v1.13 came out and broke shizzle again 😂
Firmware v1.12.3 seems to reboot the device when the config is pushed 😬

[koenhendriks]

I explicitly asked for changes between 1.12 and 1.13 before the release and to quote the creator of Button+:

No changes in the config between 1.12 and 1.13

Do you think you can add the 1.13 as well?

[koenhendriks]

Thanks a lot for your work on this! I hope this will help fix config changes faster in the future.

Really nice that you also added tests for this 👍

[koenhendriks]

@scspijker Just 1 failing CI pipeline I see. Could you take a look? I'm not really sure what the CI actually tries because it was added by @bolkedebruin

[scspijker]

@scspijker Just 1 failing CI pipeline I see. Could you take a look? I'm not really sure what the CI actually tries because it was added by @bolkedebruin

I'll take a look 👍

[scspijker]

@koenhendriks CI should be fixed, and now also runs the pytest automatically 💪

Let's fix 1.13 in a new PR.

[scspijker]

@koenhendriks okay, let's try that one more time (hopefully 😂 ). After doing some setup I could run the GHA's in my own repo, and the build now works there. The latest ubuntu runner image uses Python 3.10, but a minimum of 3.11 is required for Home Assistant. This is now setup in build.yaml, also caching dependencies.

[koenhendriks]

I might take a look at the settings of the repo, not sure why I should manually give permission for each CI run...

[scspijker]

I might take a look at the settings of the repo, not sure why I should manually give permission for each CI run...

You have limited "free" minutes with open source repo's. So somebody with permissions (like CODE-OWNER) has to approve before CI runs. Else bad actors can use all your free minutes by just opening 200 PR's at once.

CI checks passed 🎉

[IBlackI]

Is it the plan to create a (beta) release with these changes?

[koenhendriks]

Just released v0.0.15