Update concept for execution space instances #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
Sep 11, 2024
masterleinad
force-pushed
the
check_execution_policy
branch
from
b7cf8e2
to
b2e84bf
Compare
dalg24
reviewed
Sep 11, 2024
Co-authored-by: Damien L-G <[email protected]>
masterleinad
commented
Sep 11, 2024
| @@ -102,8 +102,7 @@ and ``OpenMPTarget``, the current state of the Kokkos |ExecutionSpaceTwo|_ conce | |||
|
|
|||
| template <typename Ex> | |||
| concept ExecutionSpace = | |||
| CopyConstructible<Ex> && | |||
| DefaultConstructible<Ex> && | |||
| SemiRegular<Ex> && | |||
There was a problem hiding this comment.
kokkos/kokkos#5398 (Kokkos 4.0.00) introduced the comparison operator. I'm not sure if that's worth mentioning.
dalg24
reviewed
Nov 6, 2024
| { ex.fence() }; | ||
| { ex.name() } -> const char*; | ||
| { ex.concurrency() } -> int; |
There was a problem hiding this comment.
Remind me, did we promise anything about the return type?
There was a problem hiding this comment.
That's how its implemented and how we describe it in all documentation so far. I don't know if there would be any motivation to change it to size_type or something the like.
There was a problem hiding this comment.
I meant more returns an integral type or something that is convertible to int.
Anyway that's fine by me if all backend do indeed return an int
Co-authored-by: Damien L-G <[email protected]>
JBludau
reviewed
Nov 6, 2024
dalg24
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to kokkos/kokkos#7319.