Make maximum results configurable #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to introduce a config file before the number of commandline parameters becomes unmaintainable? |
|
Having good defaults ensures that only a few parameters needs to be used. IMO no need for a config file - at least not yet (?) |
lonvia
reviewed
Apr 17, 2024
| request.setLimit(parseInt(webRequest, "limit")); | ||
| Integer limit = parseInt(webRequest, "limit"); | ||
| if(limit != null) | ||
| request.setLimit(Integer.max(Integer.min(limit, maxResults), 1)); |
There was a problem hiding this comment.
Sorry, style nitpicking: please add a space after 'if' and always curly braces, even for one-liners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the maximum results for forward and reverse search is both at 50. It might be interesting to reduce this value for forward search (to reduce maximum load) and/or increase this value for reverse search (for broader POI searches).