Skip to content

Commit

Permalink
Error reporting in DeploymentTarget/DeploymentTargetClaim.
Browse files Browse the repository at this point in the history
  • Loading branch information
Jayendra Parsai authored and jgwest committed Jan 6, 2024
1 parent ecad524 commit 18f545e
Show file tree
Hide file tree
Showing 6 changed files with 302 additions and 2 deletions.
3 changes: 3 additions & 0 deletions api/v1alpha1/deploymenttarget_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ type DeploymentTargetKubernetesClusterCredentials struct {
// DeploymentTargetStatus defines the observed state of DeploymentTarget
type DeploymentTargetStatus struct {
Phase DeploymentTargetPhase `json:"phase,omitempty"`

// Conditions is an array of the DeploymentTarget's status conditions
Conditions []metav1.Condition `json:"conditions,omitempty"`
}

type DeploymentTargetPhase string
Expand Down
3 changes: 3 additions & 0 deletions api/v1alpha1/deploymenttargetclaim_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ type DeploymentTargetClassName string
// DeploymentTargetClaimStatus defines the observed state of DeploymentTargetClaim
type DeploymentTargetClaimStatus struct {
Phase DeploymentTargetClaimPhase `json:"phase,omitempty"`

// Conditions is an array of the DeploymentTargetClaim's status conditions
Conditions []metav1.Condition `json:"conditions,omitempty"`
}

type DeploymentTargetClaimPhase string
Expand Down
18 changes: 16 additions & 2 deletions api/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

70 changes: 70 additions & 0 deletions config/crd/bases/appstudio.redhat.com_deploymenttargetclaims.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,76 @@ spec:
description: DeploymentTargetClaimStatus defines the observed state of
DeploymentTargetClaim
properties:
conditions:
description: Conditions is an array of the DeploymentTargetClaim's
status conditions
items:
description: "Condition contains details for one aspect of the current
state of this API Resource. --- This struct is intended for direct
use as an array at the field path .status.conditions. For example,
type FooStatus struct{ // Represents the observations of a foo's
current state. // Known .status.conditions.type are: \"Available\",
\"Progressing\", and \"Degraded\" // +patchMergeKey=type // +patchStrategy=merge
// +listType=map // +listMapKey=type Conditions []metav1.Condition
`json:\"conditions,omitempty\" patchStrategy:\"merge\" patchMergeKey:\"type\"
protobuf:\"bytes,1,rep,name=conditions\"` \n // other fields }"
properties:
lastTransitionTime:
description: lastTransitionTime is the last time the condition
transitioned from one status to another. This should be when
the underlying condition changed. If that is not known, then
using the time when the API field changed is acceptable.
format: date-time
type: string
message:
description: message is a human readable message indicating
details about the transition. This may be an empty string.
maxLength: 32768
type: string
observedGeneration:
description: observedGeneration represents the .metadata.generation
that the condition was set based upon. For instance, if .metadata.generation
is currently 12, but the .status.conditions[x].observedGeneration
is 9, the condition is out of date with respect to the current
state of the instance.
format: int64
minimum: 0
type: integer
reason:
description: reason contains a programmatic identifier indicating
the reason for the condition's last transition. Producers
of specific condition types may define expected values and
meanings for this field, and whether the values are considered
a guaranteed API. The value should be a CamelCase string.
This field may not be empty.
maxLength: 1024
minLength: 1
pattern: ^[A-Za-z]([A-Za-z0-9_,:]*[A-Za-z0-9_])?$
type: string
status:
description: status of the condition, one of True, False, Unknown.
enum:
- "True"
- "False"
- Unknown
type: string
type:
description: type of condition in CamelCase or in foo.example.com/CamelCase.
--- Many .condition.type values are consistent across resources
like Available, but because arbitrary conditions can be useful
(see .node.status.conditions), the ability to deconflict is
important. The regex it matches is (dns1123SubdomainFmt/)?(qualifiedNameFmt)
maxLength: 316
pattern: ^([a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*/)?(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])$
type: string
required:
- lastTransitionTime
- message
- reason
- status
- type
type: object
type: array
phase:
type: string
type: object
Expand Down
70 changes: 70 additions & 0 deletions config/crd/bases/appstudio.redhat.com_deploymenttargets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,76 @@ spec:
status:
description: DeploymentTargetStatus defines the observed state of DeploymentTarget
properties:
conditions:
description: Conditions is an array of the DeploymentTarget's status
conditions
items:
description: "Condition contains details for one aspect of the current
state of this API Resource. --- This struct is intended for direct
use as an array at the field path .status.conditions. For example,
type FooStatus struct{ // Represents the observations of a foo's
current state. // Known .status.conditions.type are: \"Available\",
\"Progressing\", and \"Degraded\" // +patchMergeKey=type // +patchStrategy=merge
// +listType=map // +listMapKey=type Conditions []metav1.Condition
`json:\"conditions,omitempty\" patchStrategy:\"merge\" patchMergeKey:\"type\"
protobuf:\"bytes,1,rep,name=conditions\"` \n // other fields }"
properties:
lastTransitionTime:
description: lastTransitionTime is the last time the condition
transitioned from one status to another. This should be when
the underlying condition changed. If that is not known, then
using the time when the API field changed is acceptable.
format: date-time
type: string
message:
description: message is a human readable message indicating
details about the transition. This may be an empty string.
maxLength: 32768
type: string
observedGeneration:
description: observedGeneration represents the .metadata.generation
that the condition was set based upon. For instance, if .metadata.generation
is currently 12, but the .status.conditions[x].observedGeneration
is 9, the condition is out of date with respect to the current
state of the instance.
format: int64
minimum: 0
type: integer
reason:
description: reason contains a programmatic identifier indicating
the reason for the condition's last transition. Producers
of specific condition types may define expected values and
meanings for this field, and whether the values are considered
a guaranteed API. The value should be a CamelCase string.
This field may not be empty.
maxLength: 1024
minLength: 1
pattern: ^[A-Za-z]([A-Za-z0-9_,:]*[A-Za-z0-9_])?$
type: string
status:
description: status of the condition, one of True, False, Unknown.
enum:
- "True"
- "False"
- Unknown
type: string
type:
description: type of condition in CamelCase or in foo.example.com/CamelCase.
--- Many .condition.type values are consistent across resources
like Available, but because arbitrary conditions can be useful
(see .node.status.conditions), the ability to deconflict is
important. The regex it matches is (dns1123SubdomainFmt/)?(qualifiedNameFmt)
maxLength: 316
pattern: ^([a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*/)?(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])$
type: string
required:
- lastTransitionTime
- message
- reason
- status
- type
type: object
type: array
phase:
type: string
type: object
Expand Down
Loading

0 comments on commit 18f545e

Please sign in to comment.