feat(STONEINTG-1006): adding to component status.lastPromotedImage #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasemAlem
force-pushed
the
STONEINTG-1006-lastpromotedimage
branch
6 times, most recently
from
be75942 to
1e83ffc
Compare
dirgim
requested review from
johnmcollier,
dirgim,
scoheb,
ralphbean,
arewm and
rcerven
|
@Katka92 pinging you here for review and awareness in light of the discussion yesterday about contract testing. |
ralphbean
approved these changes
Jul 31, 2024
dirgim
reviewed
Jul 31, 2024
kasemAlem
force-pushed
the
STONEINTG-1006-lastpromotedimage
branch
from
1e83ffc to
cc0e529
Compare
|
@Katka92 any concerns with this before we merge it? |
johnmcollier
approved these changes
Jul 31, 2024
|
@ralphbean Thank you for pinging me. @rohitkrai03 can you please confirm it is not a breaking change for the UI? |
jsztuka
reviewed
Aug 5, 2024
Josh-Everett
approved these changes
Aug 5, 2024
Signed-off-by: Kasem Alem <[email protected]>
kasemAlem
force-pushed
the
STONEINTG-1006-lastpromotedimage
branch
from
cc0e529 to
f4ac470
Compare
@rohitkrai03 , @Katka92 we still waiting for a confirmation if it's safe to merge this PR , can you please update ? |
|
@kasemAlem Its safe to merge this PR. I don't see it causing any issues on the UI side as its just adding a new field in status. |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new status field lastPromotedImage , for more details review in STONEINTG-1006