Merge pull request #518 from MartinBasti/no-auth-for-nothing

fix(STONEINTG-751): don't auth when there is nothing to report

status/reporters.go

@@ -674,6 +674,13 @@ func (r *GitHubReporter) ReportStatusForSnapshot(k8sClient client.Client, ctx co
 		return err
 	}
 
+	if len(statuses.GetStatuses()) == 0 {
+		// no tests to report, skip
+		logger.Info("No test result to report to GitHub, skipping",
+			"snapshot.Namespace", snapshot.Namespace, "snapshot.Name", snapshot.Name)
+		return nil
+	}
+
 	labels := snapshot.GetLabels()
 
 	owner, found := labels[gitops.PipelineAsCodeURLOrgLabel]

status/reporters_test.go

@@ -529,6 +529,7 @@ var _ = Describe("GitHubReporter", func() {
 
 		It("doesn't report status when the credentials are invalid/missing", func() {
 			// Invalid installation ID value
+			hasSnapshot.Annotations["test.appstudio.openshift.io/status"] = "[{\"scenario\":\"scenario1\",\"status\":\"Pending\",\"lastUpdateTime\":\"2023-07-26T16:57:49+02:00\",\"details\":\"pending\"}]"
 			hasSnapshot.Annotations["pac.test.appstudio.openshift.io/installation-id"] = "bad-installation-id"
 			err := reporter.ReportStatusForSnapshot(mockK8sClient, context.TODO(), &logger, hasSnapshot)
 			Expect(err).ToNot(BeNil())
@@ -552,6 +553,12 @@ var _ = Describe("GitHubReporter", func() {
 			Expect(err).ToNot(BeNil())
 		})
 
+		It("doesn't report status when there are no tests", func() {
+			err := reporter.ReportStatusForSnapshot(mockK8sClient, context.TODO(), &logger, hasSnapshot)
+			Expect(err).To(Succeed())
+			Expect(mockGitHubClient.UpdateCheckRunResult.cra).To(BeNil())
+		})
+
 		It("reports snapshot tests status via CheckRuns", func() {
 			// Create an pending CheckRun
 			hasSnapshot.Annotations["test.appstudio.openshift.io/status"] = "[{\"scenario\":\"scenario1\",\"status\":\"Pending\",\"lastUpdateTime\":\"2023-07-26T16:57:49+02:00\",\"details\":\"pending\"}]"