You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the condition for seting scenario status to valid. The previous condition would return false if the condition was not present, so it would not work for scenarios that were created for e2e or load testing
See IsStatusConditionFalse for more context - it returns false if status condition is not present
* Change the condition for seting scenario status to valid
The previous condition would return false if the
condition was not present, so it would not work
for scenarios that were created for e2e testing
Signed-off-by: dirgim <[email protected]>
Since the package is https://github.com/redhat-appstudio/integration-service and relates to the scenario controller , don't we need an update to infra-deployment and thereafter redeployment to a cluster to make the change effective?
1. What made the integration test scenario status:condition[] array empty and how your PR changes that?
2. Did and how did it affect the framework.AsKubeDeveloper.IntegrationController.CreateIntegrationTestScenario_beta1 function success?
3. Does it affects the snapshot creation?
On what of the below snapshot error types it affects (or on others)?
Snapshot type and indicators of errors
https://redhat-internal.slack.com/archives/D059BDTQKC5/p1698325647612289
https://redhat-internal.slack.com/archives/D059BDTQKC5/p1698325754793929
https://redhat-internal.slack.com/archives/D059BDTQKC5/p1698326275772429
4. Since the package is https://github.com/redhat-appstudio/integration-service and relates to the scenario controller , don't we need an update to infra-deployment and thereafter redeployment to a cluster to make the change effective?
5. Did you create a Bug for that issue?
The previous version of the if condition here would return false if the IntegrationTestScenarioValid condition was not present, so it would not trigger for scenarios that were created for e2e or load testing as their .status.conditions field would not be present upon creation. This change makes this correctly detect that it needs to set the IntegrationTestScenarioValid condition to true.
Yes it did, because of the above changes the scenario controller will be able to update the status.conditions with the IntegrationTestScenarioValid condition after they are created via CreateIntegrationTestScenario_beta1.
This does not affect Snapshot creation or handling, only IntegrationTestScenario CR handling in the scenario controller.
Yes, this change will need to be merged and deployed via infra-deployments.
This PR is a follow-up change for STONEINTG-583 to account for this edge case.
Hi @naftalysh please be patient as this change is under review by the team and will be merged and deployed after it gets approved. The STONEINTG-583 story cannot be reopened in the current workflow.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dirgim
force-pushed
the
STONEINTG-583-3
branch
from
Maintainers will complete the following section