Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(STONEINTG-709): add support missing info of build PLR error #506

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix(STONEINTG-709): add support missing info of build PLR error #506

merged 1 commit into from
Jan 18, 2024

Conversation

kasemAlem
Copy link
Contributor

Fix STONEINTG-709 , adding new error handler for the missing params error returned by build PipelineRun and stop the PLR to be returned to the reconcile queue .

@kasemAlem kasemAlem marked this pull request as draft January 8, 2024 09:55
@kasemAlem kasemAlem marked this pull request as ready for review January 8, 2024 11:45
@hongweiliu17
Copy link
Contributor

hongweiliu17 commented Jan 9, 2024

We may also replace the errors such as fmt.Errorf("couldn't find the CHAINS-GIT_URL PipelineRun result") link with MissingInfoInPipelineRunError() and check the error returned by prepareSnapshotForPipelineRun(), and then update the build PLR annotation and ContinueProcessing() if IsMissingInfoInPipelineRunError(err) is true

@kasemAlem
Copy link
Contributor Author

#506 (comment)
@hongweiliu17 is there a specific build PLR annotation that I should update or I should create a new one ?

controllers/buildpipeline/buildpipeline_adapter.go Outdated Show resolved Hide resolved
controllers/buildpipeline/buildpipeline_adapter.go Outdated Show resolved Hide resolved
controllers/buildpipeline/buildpipeline_adapter.go Outdated Show resolved Hide resolved
controllers/buildpipeline/buildpipeline_adapter.go Outdated Show resolved Hide resolved
controllers/buildpipeline/buildpipeline_adapter.go Outdated Show resolved Hide resolved
@hongweiliu17
Copy link
Contributor

#506 (comment) @hongweiliu17 is there a specific build PLR annotation that I should update or I should create a new one ?

You may use this one https://github.com/redhat-appstudio/integration-service/pull/489/files#diff-16fb634f123aeba9508751c94b6a61320bf6877bdb01ff6f00da2a72b92ee432R3

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (90837ac) 69.14% compared to head (dbf37fd) 69.35%.
Report is 1 commits behind head on main.

Files Patch % Lines
controllers/buildpipeline/buildpipeline_adapter.go 0.00% 8 Missing ⚠️
tekton/utils.go 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
+ Coverage   69.14%   69.35%   +0.21%     
==========================================
  Files          44       44              
  Lines        4995     5013      +18     
==========================================
+ Hits         3454     3477      +23     
+ Misses       1208     1205       -3     
+ Partials      333      331       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kasemAlem
Copy link
Contributor Author

#506 (comment) @hongweiliu17 is there a specific build PLR annotation that I should update or I should create a new one ?

You may use this one https://github.com/redhat-appstudio/integration-service/pull/489/files#diff-16fb634f123aeba9508751c94b6a61320bf6877bdb01ff6f00da2a72b92ee432R3

thanks @hongweiliu17 , I've used the same one here

Copy link
Collaborator

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot removed the lgtm label Jan 18, 2024
@kasemAlem kasemAlem requested a review from MartinBasti January 18, 2024 10:09
@kasemAlem
Copy link
Contributor Author

/test integration-service-e2e

@openshift-ci openshift-ci bot added the lgtm label Jan 18, 2024
@openshift-ci openshift-ci bot removed the lgtm label Jan 18, 2024
Copy link

openshift-ci bot commented Jan 18, 2024

New changes are detected. LGTM label has been removed.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants