-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stoneintg-753): requeue release creation until timeout #523
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
==========================================
+ Coverage 69.23% 69.40% +0.16%
==========================================
Files 44 44
Lines 5012 5020 +8
==========================================
+ Hits 3470 3484 +14
+ Misses 1211 1205 -6
Partials 331 331 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except this small issue with not using constants
89516af
to
6267d53
Compare
Prior to this commit the integration service would requeue release creation indefinitely if it failed. If a release quota was hit then releases would be backed up then be created all at once and overwhelm user workspaces with potentially no-longer-relevant releases. This change sets a timeout of three hours for requeued releases, after which creating a release for that snapshot will fail. Signed-off-by: Ryan Cole <[email protected]>
6267d53
to
5c58fab
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Prior to this commit the integration service would requeue release creation indefinitely if it failed. If a release quota was hit then releases would be backed up then be created all at once and overwhelm user workspaces with potentially no-longer-relevant releases. This change sets a timeout of three hours for requeued releases, after which creating a release for that snapshot will fail.
Maintainers will complete the following section