Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stoneintg-753): requeue release creation until timeout #523

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

14rcole
Copy link
Collaborator

@14rcole 14rcole commented Jan 18, 2024

Prior to this commit the integration service would requeue release creation indefinitely if it failed. If a release quota was hit then releases would be backed up then be created all at once and overwhelm user workspaces with potentially no-longer-relevant releases. This change sets a timeout of three hours for requeued releases, after which creating a release for that snapshot will fail.

Maintainers will complete the following section

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7940525) 69.23% compared to head (5c58fab) 69.40%.

Files Patch % Lines
controllers/snapshot/snapshot_adapter.go 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
+ Coverage   69.23%   69.40%   +0.16%     
==========================================
  Files          44       44              
  Lines        5012     5020       +8     
==========================================
+ Hits         3470     3484      +14     
+ Misses       1211     1205       -6     
  Partials      331      331              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MartinBasti MartinBasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except this small issue with not using constants

controllers/snapshot/snapshot_adapter.go Outdated Show resolved Hide resolved
Prior to this commit the integration service would requeue
release creation indefinitely if it failed.  If a release quota
was hit then releases would be backed up then be created all at
once and overwhelm user workspaces with potentially no-longer-relevant
releases.  This change sets a timeout of three hours for requeued
releases, after which creating a release for that snapshot will fail.

Signed-off-by: Ryan Cole <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
3.7% Duplication on New Code

See analysis details on SonarCloud

@openshift-ci openshift-ci bot added the lgtm label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants