Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(STONEINTG-1091): don't set commitStatus for PR/MR from forked repo #943

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

hongweiliu17
Copy link
Contributor

@hongweiliu17 hongweiliu17 commented Nov 25, 2024

  • Don't set commitStatus if the PR/MR is from forked repo since the limitation access

Signed-off-by: Hongwei Liu [email protected]

Maintainers will complete the following section

@hongweiliu17
Copy link
Contributor Author

/ok-to-test

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 54.90196% with 23 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@618b3e3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
status/reporter_github.go 50.00% 16 Missing and 3 partials ⚠️
status/reporter_gitlab.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #943   +/-   ##
=======================================
  Coverage        ?   66.20%           
=======================================
  Files           ?       43           
  Lines           ?     5871           
  Branches        ?        0           
=======================================
  Hits            ?     3887           
  Misses          ?     1635           
  Partials        ?      349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Don't set commitStatus if the PR/MR is from forked repo since the
  limitation access

Signed-off-by: Hongwei Liu <[email protected]>
@hongweiliu17 hongweiliu17 marked this pull request as ready for review November 26, 2024 02:35
@hongweiliu17
Copy link
Contributor Author

/retest

Copy link
Contributor

@chipspeak chipspeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot removed the lgtm label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants