Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: begin referencing status.lastPromotedImage #944

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

14rcole
Copy link
Collaborator

@14rcole 14rcole commented Nov 25, 2024

Attempt to use status.lastPrommotedImage as the source of truth for the gcl. Fall back on the spec.containerImage field, despite the fact that it may have been changed by imageRepository

Maintainers will complete the following section

Attempt to use status.lastPrommotedImage as the source of truth
for the gcl.  Fall back on the spec.containerImage field, despite
the fact that it may have been changed by imageRepository

Signed-off-by: Ryan Cole <[email protected]>
Copy link
Contributor

@Josh-Everett Josh-Everett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hongweiliu17 hongweiliu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I agree with falling back to the containerImage if the lastPromotedImage is not set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants