feat(KFLUXBUGS-1889): set ITS timeouts from annotations #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
* If the ITS has any of the following annotations: test.appstudio.openshift.io/pipeline_timeout test.appstudio.openshift.io/tasks_timeout test.appstudio.openshift.io/finally_timeout * Use them to overwrite the default timeouts that are set in configmaps Signed-off-by: dirgim <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
dirgim
force-pushed
the
KFLUXBUGS-1889-1
branch
from
e12cd4b to
cf087fe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #949 +/- ##
=======================================
Coverage ? 66.06%
=======================================
Files ? 43
Lines ? 5887
Branches ? 0
=======================================
Hits ? 3889
Misses ? 1649
Partials ? 349 ☔ View full report in Codecov by Sentry. |
|
/retest |
dirgim
requested review from
hongweiliu17,
jsztuka,
Josh-Everett,
kasemAlem,
sonam1412,
dheerajodha,
14rcole,
jencull and
chipspeak
as code owners
dirgim
changed the title
kasemAlem
approved these changes
Dec 4, 2024
|
LGTM |
Josh-Everett
approved these changes
Dec 4, 2024
sonam1412
approved these changes
Dec 5, 2024
|
@dirgim Are you also planning to add a documentation for the users for the steps to follow ? |
|
@sonam1412 yes, working on that right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dirgim [email protected]
Maintainers will complete the following section