Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: requeue after an hour if creating Snapshot is forbidden #964

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

dirgim
Copy link
Collaborator

@dirgim dirgim commented Dec 13, 2024

  • If the snapshot creation error encounters a Forbidden error it probably ran into a quota issue which may get resolved but not within 15 minutes of standard requeueing

Signed-off-by: dirgim [email protected]

Maintainers will complete the following section

* If the snapshot creation error encounters a Forbidden error
  it probably ran into a quota issue which may get resolved
  but not within 15 minutes of standard requeueing

Signed-off-by: dirgim <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
Copy link

openshift-ci bot commented Dec 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@c25127c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../controller/buildpipeline/buildpipeline_adapter.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage        ?   63.86%           
=======================================
  Files           ?       49           
  Lines           ?     6094           
  Branches        ?        0           
=======================================
  Hits            ?     3892           
  Misses          ?     1855           
  Partials        ?      347           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirgim
Copy link
Collaborator Author

dirgim commented Dec 13, 2024

/retest

Copy link
Contributor

@jencull jencull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants