Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing rubocop check #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

russell
Copy link

@russell russell commented Aug 19, 2020

Seems the rubocop.yml is a bit out of date and causing failures

$ bundle exec rubocop                                                                                                              [0]
.rubocop.relaxed.yml: Metrics/LineLength has the wrong namespace - should be Layout
Error: The `Naming/UncommunicativeMethodParamName` cop has been renamed to `Naming/MethodParameterName`.
(obsolete configuration found in .rubocop.yml, please update it)

```
$ bundle exec rubocop                                                                                                              [0]
.rubocop.relaxed.yml: Metrics/LineLength has the wrong namespace - should be Layout
Error: The `Naming/UncommunicativeMethodParamName` cop has been renamed to `Naming/MethodParameterName`.
(obsolete configuration found in .rubocop.yml, please update it)
```
@russell
Copy link
Author

russell commented Sep 3, 2020

@kke are you available to review?

@kke
Copy link
Contributor

kke commented Sep 4, 2020

@kke are you available to review?

Someone using this? :) The Kontena company went bankrupt in december 2019 and ceased operations. I no longer have the permissions to merge or write. Feel free to fork.

@russell
Copy link
Author

russell commented Sep 4, 2020

Yeah Zendesk is using it! It's great. We are moving away from using Thor and clamp/clamp-completer was a natural fit! Thanks for putting the time into writing this library

Is there a possibility for us to get access to https://rubygems.org/gems/clamp-completer so we can keep the existing gem name?

@kke
Copy link
Contributor

kke commented Sep 9, 2020

Yeah Zendesk is using it! It's great. We are moving away from using Thor and clamp/clamp-completer was a natural fit! Thanks for putting the time into writing this library

Is there a possibility for us to get access to https://rubygems.org/gems/clamp-completer so we can keep the existing gem name?

Yes, just need your rubygems.org email (wasn't the one in your github profile)

@russell
Copy link
Author

russell commented Sep 10, 2020

Hey, sorry, i should have had one before i asked. I have created one here https://rubygems.org/profiles/russell

Thanks!

@kke
Copy link
Contributor

kke commented Sep 15, 2020

Hey, sorry, i should have had one before i asked. I have created one here https://rubygems.org/profiles/russell

Thanks!

$ gem owner clamp-completer -a [email protected]                                                                                                                                                                                                                                                                                                                      Tue Sep 15 07:36:58 2020
Owner added successfully.
Owners for gem: clamp-completer
- [email protected]
- [email protected]

You should be able to push now.

@russell
Copy link
Author

russell commented Sep 15, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants