Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kong1dot1 #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Kong1dot1 #38

wants to merge 1 commit into from

Conversation

mtmail
Copy link
Contributor

@mtmail mtmail commented Nov 12, 2019

Splits /apis endpoint into /routes and /services that Kong 1.0 introduced. We're running this fine for 6 months now. First Kong 1.1, currently Kong 1.4

@mtmail
Copy link
Contributor Author

mtmail commented Nov 20, 2019

I split off the Travis and rubocop fixes into separate PRs.

@irfn
Copy link

irfn commented Dec 11, 2019

@mtmail @nevalla This is a very useful PR. Is there anything blocking this?

@irfn
Copy link

irfn commented Dec 11, 2019

@mtmail if you are using this rt now, is there a gem version published somewhere?

@irfn
Copy link

irfn commented Dec 12, 2019

@mtmail i was not able to add upstreams for using this and getting
Kong::Error ({"message":"schema violation (upstream_id: unknown field)","name":"schema violation","fields":{"upstream_id":"unknown field"},"code":2})

the docs show target structure has changed https://docs.konghq.com/1.4.x/admin-api/#add-target

@irfn
Copy link

irfn commented Dec 12, 2019

@mtmail

This is a workaround i am doing to make this work
irfn@a0ee591
hope you can address this.

@irfn
Copy link

irfn commented Dec 12, 2019

Actually ignore the above workaround. It only allows you to create and not view.
Here i have updated this to handle update & view (still workaround quality)

irfn@758974e

@arthurmde
Copy link
Contributor

@mtmail @irfn sometimes it seems like this gem is not being maintained anymore, but I'm not sure. Did you publish your fork publicly in the Rubygems?

Do you intend to maintain a fork to let it updated with new Kong versions? I'm interested to help.

@nevalla
Copy link
Contributor

nevalla commented Dec 17, 2019

Hi, sorry for not giving any feedback here. Finally, I have now time to push this further. So, I'll test this out with the latest version of Kong and review the PR.

After we get this merged I'll create a beta/rc build so you can test it too.

@nevalla
Copy link
Contributor

nevalla commented Dec 17, 2019

Please could you rebase and resolve conflicts. Meta PRs are now merged so it would be easier to review this PR.

@mtmail mtmail force-pushed the kong1dot1 branch 2 times, most recently from a0b8b01 to c782bbc Compare December 17, 2019 14:42
@mtmail
Copy link
Contributor Author

mtmail commented Dec 17, 2019

I split off the bundler,rake changes into a separate PR #42

@irfn
Copy link

irfn commented Dec 17, 2019

@mtmail do you intend to work on Kong 1.4.x support? I mentioned the issue in the thread.

@mtmail
Copy link
Contributor Author

mtmail commented Dec 17, 2019

@irfn I'm using this library with 1.4.0 already, I guess not the feature you mention. Can you create a separate github issue?

@mtmail
Copy link
Contributor Author

mtmail commented Dec 17, 2019

Rebased, squashed, and tests passing. I set version to 0.4.0 and added a changelog entry.

@irfn
Copy link

irfn commented Dec 19, 2019

@irfn I'm using this library with 1.4.0 already, I guess not the feature you mention. Can you create a separate github issue?

Ill retest and raise issue once this is merged. thanks!

@YusukeIwaki
Copy link

Any update?

We are really looking forward to use Kong::Service and working Kong::JWT :)

@mtmail
Copy link
Contributor Author

mtmail commented Dec 11, 2020

My fork works with Kong 2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants