Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Махлонов Дмитрий #210
base: master
Are you sure you want to change the base?
Махлонов Дмитрий #210
Changes from 6 commits
1930cd3
9f5c6d9
5cea3fe
d8580ab
d8740ca
4d03462
812deec
bd9da6e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Кажется bitmapGenerator должен только рисовать картинку, а не генерировать размеры и позиции для прямоугольников. Предлагаю эту информацию вынести в CloudWord или в какой-нибудь DrowingCloudWord
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Из-за private set настройки стали по сути бесполезны, ведь ими нельзя управлять. Почему решил сделать именно так?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
задумывал настройки неизменяемым объектом, если что-то нужно поменять - создаем новый объект настроек
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А куда сохранять? На мой взгляд это уже не столько настройки конкретной реализации, сколько правила поведения в целом
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Аналогично
BitmapGeneratorSettings
и во всех остальных настройках. Почему решил сделать так и про конструктор?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Да, это будет работать. Но совет на будущее - стараться не транслировать насквозь своей библиотеки что-то из зависимостей. Если захочешь переписать логику, то придётся отказаться и от такого параметра. А пользователи его используют. Лучше создавать свою прослойку моделей, которые уже трансформировать во что захочется