Минеев Максим #233
Open
Минеев Максим #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasha0666
reviewed
Dec 14, 2024
ObjectPrinting/PrintingConfig.cs
Outdated
Comment on lines
79
to
104
| private string PrintPropertiesToString(object obj, int nestingLevel) | ||
| { | ||
| var type = obj.GetType(); | ||
| var identation = new string('\t', nestingLevel + 1); | ||
| var items = (from propertyInfo in type.GetProperties() | ||
| select Serialize(propertyInfo.GetValue(obj), propertyInfo.PropertyType, propertyInfo.Name, nestingLevel + 1) | ||
| into serializedProperty | ||
| where serializedProperty != string.Empty | ||
| select identation + serializedProperty).ToList(); | ||
|
|
||
| return string.Join(",\n", items); | ||
| } | ||
|
|
||
| private string PrintFieldsToString(object obj, int nestingLevel) | ||
| { | ||
| var type = obj.GetType(); | ||
| var identation = new string('\t', nestingLevel + 1); | ||
| var items = (from fieldInfo in type.GetFields() | ||
| select Serialize(fieldInfo.GetValue(obj), fieldInfo.FieldType, fieldInfo.Name, nestingLevel + 1) | ||
| into serializedProperty | ||
| where serializedProperty != string.Empty | ||
| select identation + serializedProperty).ToList(); | ||
|
|
||
| return string.Join(",\n", items); | ||
| } | ||
|
|
ObjectPrinting/PrintingConfig.cs
Outdated
Comment on lines
122
to
126
| value = PrintDictionary((IDictionary)valueToSerialize, level); | ||
| if (valueToSerialize is string stringValue && MaxLengths.TryGetValue(name, out var maxLength)) | ||
| value = stringValue[..Math.Min(value.Length, maxLength)]; | ||
| if (value == "") value = PrintToString(valueToSerialize, level + 1); | ||
| if (value.Length > 0) return name + " = " + value; |
ObjectPrinting/PrintingConfig.cs
Outdated
Comment on lines
19
to
20
| private readonly HashSet<string> excludedProperties = []; | ||
| private readonly HashSet<object> visited = []; |
There was a problem hiding this comment.
Посмотри на логику visited, тоже может быть баг
Comment on lines
23
to
24
| Height = 123.4, | ||
| Id = new Guid() |
There was a problem hiding this comment.
Я бы брал не 00000000-0000-0000-0000-000000000000, а какие-то опреденные Guid
ObjectPrintingTests/Person.cs
Outdated
Comment on lines
10
to
11
| public List<int> Weigths { get; set; } | ||
| public Dictionary<string, int> Dict { get; set; } |
There was a problem hiding this comment.
Все были связаны с человеком, а словарь просто Dict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Pasha0666