Калентьев Илья tg: @m1nus0ne #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsitin
reviewed
Dec 14, 2024
Comment on lines
+3
to
+9
| Name = Mary | ||
| Surname = null | ||
| Age = 0 | ||
| Height = 0 | ||
| BirthDate = 01.01.0001 0:00:00 | ||
| Address = null | ||
| Parent = null |
There was a problem hiding this comment.
Прикольно, что ты отдельно обрабатываешь сериализацию словаря, но тогда тут должны быть отступы
Comment on lines
+137
to
+155
| [Test] | ||
| public void ObjectPrinter_ShouldCorrectPrintArray() | ||
| { | ||
| var list = new[] { new Person { Name = "Mary" }, new Person { Name = "Alice" } }; | ||
|
|
||
| var printer = ObjectPrinter.For<Person[]>(); | ||
|
|
||
| Approvals.Verify(printer.PrintToString(list)); | ||
| } | ||
|
|
||
| [Test] | ||
| public void ObjectPrinter_ShouldCorrectPrintList() | ||
| { | ||
| var list = new List<Person> { new Person { Name = "Mary" }, new Person { Name = "Alice" } }; | ||
|
|
||
| var printer = ObjectPrinter.For<List<Person>>(); | ||
|
|
||
| Approvals.Verify(printer.PrintToString(list)); | ||
| } |
There was a problem hiding this comment.
Для тестов сериализации коллекций не хватает approved файлов. Сериализация коллекций выглядит странно, например, если в классе будет поле с массивом чисел, они выведутся подряд без разделителей
|
|
||
| namespace ObjectPrinting; | ||
|
|
||
| public static class ObjectPrintingExtension |
There was a problem hiding this comment.
Нет изменений ObjectPrinter`а, поэтому напишу здесь, класс можно было сделать static. Создавать экземпляры класса сейчас не имеет смысла
Comment on lines
+26
to
+27
| typeof(int), typeof(double), typeof(float), typeof(string), | ||
| typeof(DateTime), typeof(TimeSpan) |
There was a problem hiding this comment.
Не хватает сериализации long и bool, в c# много различных примитивов, но эти часто используются, поэтому их стоило добавить
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.