Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vue3 #133

Closed
wants to merge 12 commits into from
Closed

Feature/vue3 #133

wants to merge 12 commits into from

Conversation

Botz
Copy link
Contributor

@Botz Botz commented Dec 23, 2020

This PR adds basic support for Vue3
#123

@lavrton
Copy link
Member

lavrton commented Dec 24, 2020

That is a very good Pull Request.

It will not work with vue@2, right?

@Botz
Copy link
Contributor Author

Botz commented Dec 24, 2020

Thx, yeah it will not work with vue2...

@lavrton
Copy link
Member

lavrton commented Dec 29, 2020

@Botz can you also take a look into tests? Are there any simple way to fix them to just enable npm run test again?

@Botz
Copy link
Contributor Author

Botz commented Dec 29, 2020

@lavrton yes of course... i think it's only a karma konfiguration problem and an old vue-test-utils dependency... i will try to fix it...

@Botz
Copy link
Contributor Author

Botz commented Jan 2, 2021

@lavrton
I managed to get the tests running. But i had to disable a few tests. Because there is a API change in vue and i can't access the child components with the related konvaNode to update the zIndex in checkOrder()

Maybe you can have a look and find another way?

This function was a little bit confusing for me at first, so maybe we can discuss if it is really necessary?!
Because, if i got it right, the zIndex which i define in an item gets overwritten by this function thats not what i would expect.

@nohns
Copy link

nohns commented Jan 11, 2021

Awesome stuff. I'm looking forward to the see Vue 3 support!

@cristianvasquez
Copy link

Looking forward to starting using Konva in Vue 3!

@sinasita
Copy link

Any news on this PR? Will it get merged? Thanks for all your work @lavrton and @Botz!

@lavrton
Copy link
Member

lavrton commented Apr 5, 2021

I am happy to merge it. But the PR needs to be finished. I don't have enough time to dive in right now. But that order issue must be fixed, all tests should pass.

@lavrton
Copy link
Member

lavrton commented Apr 5, 2021

I fixed some tests here: https://github.com/konvajs/vue-konva/tree/Botz-feature/vue3
But still not all.

@Botz
Copy link
Contributor Author

Botz commented Apr 5, 2021

@lavrton thx for your help
I fixed the deep order tests(had to make the findKonvaNode function recursive again),
and fixed the validation tests.

But there is still one failing test: checking for loop order

[Vue warn]: Unhandled error during execution of scheduler flush. This is likely a Vue internals bug. Please open an issue 

Because the render function doesn't really render a Node the Node.insertBefore() function failes. I think this is a problem with vue3 internals.

@Nukron
Copy link

Nukron commented Jun 2, 2021

Really looking forward to use Konva with Vue3! Thanks for the amazing work @lavrton and @Botz!
Are there any news?

@lavrton
Copy link
Member

lavrton commented Jun 2, 2021

I am not sure I will be able to finish that issue from my side.

With vue3 I want to change how vue-konva works. vue3 has some new API for custom renders. But I wasn't able to find any good demos, examples.

If someone can help here, it will be extremely useful.
I saw this example: https://github.com/huruji/vuvas, but as I can see it creates a completely new renderer. But what we need is canvas renderer inside DOM renderer (usual vue). I didn't see any examples of that.

@h-guliyev
Copy link

h-guliyev commented Jun 9, 2021

Hi as for example you might look at vugel

Also, they have just released vue 3.1 which has vue2 compatibility api

Vue 3.1 is release is dedicated to the Migration Build: a build of Vue 3 that offers Vue 2 compatible behavior to help migrating Vue 2 codebases to Vue 3.

This might be just the right time to add vue 3 support

@wulucxy
Copy link

wulucxy commented Aug 5, 2021

HI,thanks for the project。How is the progress now?

@DavidVaness
Copy link

Thank you for the work guys! keep it up 💪🏼
would love to use this with vue 3

@jgiovanni
Copy link

Looking forward to this being merged also! initKonva has a debugger statement in it.

initKonva: function initKonva() {
      debugger;

@boboldehampsink
Copy link

Other than the debugger; mentioned above this seems to work fine. Can we remove this statement from the package to make it usable?

@lavrton lavrton mentioned this pull request Oct 12, 2021
@lavrton
Copy link
Member

lavrton commented Nov 5, 2021

Closing by #172

@lavrton lavrton closed this Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.