-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/vue3 #133
Feature/vue3 #133
Conversation
That is a very good Pull Request. It will not work with |
Thx, yeah it will not work with vue2... |
@Botz can you also take a look into tests? Are there any simple way to fix them to just enable |
@lavrton yes of course... i think it's only a karma konfiguration problem and an old vue-test-utils dependency... i will try to fix it... |
@lavrton Maybe you can have a look and find another way? This function was a little bit confusing for me at first, so maybe we can discuss if it is really necessary?! |
Awesome stuff. I'm looking forward to the see Vue 3 support! |
Looking forward to starting using Konva in Vue 3! |
I am happy to merge it. But the PR needs to be finished. I don't have enough time to dive in right now. But that order issue must be fixed, all tests should pass. |
… Botz-feature/vue3
I fixed some tests here: https://github.com/konvajs/vue-konva/tree/Botz-feature/vue3 |
@lavrton thx for your help But there is still one failing test:
Because the render function doesn't really render a Node the |
I am not sure I will be able to finish that issue from my side. With vue3 I want to change how If someone can help here, it will be extremely useful. |
Hi as for example you might look at vugel Also, they have just released vue 3.1 which has vue2 compatibility api
This might be just the right time to add vue 3 support |
HI,thanks for the project。How is the progress now? |
Thank you for the work guys! keep it up 💪🏼 |
Looking forward to this being merged also! initKonva has a debugger statement in it. initKonva: function initKonva() {
debugger; |
Other than the debugger; mentioned above this seems to work fine. Can we remove this statement from the package to make it usable? |
Closing by #172 |
This PR adds basic support for Vue3
#123