Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added debug message in case test fails #1191

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

mguetta1
Copy link
Contributor

No description provided.

Signed-off-by: Maayan Hadasi <[email protected]>
Copy link
Collaborator

@ibragins ibragins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but test will fail if value is NaN. I believe we can pass the test if this value doesn't exist. @Shveta22 WDYT?

@mguetta1
Copy link
Contributor Author

LGTM, but test will fail if value is NaN. I believe we can pass the test if this value doesn't exist. @Shveta22 WDYT?

Thanks @ibragins.
As I understood from Devs - the ansible play recap must be there at this stage (once Tackle CR is in successful state)
cc: @jmontleon @fbladilo

@ibragins
Copy link
Collaborator

LGTM, but test will fail if value is NaN. I believe we can pass the test if this value doesn't exist. @Shveta22 WDYT?

Thanks @ibragins. As I understood from Devs - the ansible play recap must be there at this stage (once Tackle CR is in successful state) cc: @jmontleon @fbladilo

In this case we shoud to several tries until this value will be there.
Something like

while (Number.isNaN(failedCount)) cy.wait(30 * SEC)

Also you can add iterations counter to be sure this will not become endless loop.

@mguetta1
Copy link
Contributor Author

@ibragins
post-upgrade test is triggered by the upgrade Jenkins pipeline only once the Tackle CR is Successful

Signed-off-by: Maayan Hadasi <[email protected]>
@sshveta sshveta merged commit b9ebb39 into konveyor:main Aug 13, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants