Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Automate language selection #853

Merged
merged 8 commits into from
Dec 5, 2023

Conversation

abrugaro
Copy link
Collaborator

@abrugaro abrugaro commented Dec 1, 2023

Solves MTA-1703 and solves a minor JF

Automates Polarion TC 408

Jenkins run 1397

image

Signed-off-by: Alejandro Brugarolas <[email protected]>
@abrugaro abrugaro changed the title []automate language selection [RFR] Automate language selection Dec 1, 2023
@abrugaro abrugaro self-assigned this Dec 1, 2023
@abrugaro abrugaro requested a review from sshveta December 1, 2023 11:46
@abrugaro abrugaro changed the title [RFR] Automate language selection [WIP] Automate language selection Dec 1, 2023
@abrugaro abrugaro added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2023
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
@@ -83,7 +83,7 @@ export class CustomMigrationTarget {
}

public delete() {
CustomMigrationTarget.open();
CustomMigrationTarget.selectLanguage(this.language);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this for delete ? Isn't java selected by default ?

@abrugaro abrugaro removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2023
@abrugaro abrugaro changed the title [WIP] Automate language selection [RFR] Automate language selection Dec 4, 2023
@sshveta sshveta merged commit 5b13e95 into konveyor:main Dec 5, 2023
6 of 7 checks passed
@abrugaro abrugaro deleted the automate-language-selection branch December 18, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants