Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add Identity and Proxy to API tests. #331

Merged
merged 2 commits into from
May 17, 2023

Conversation

aufi
Copy link
Member

@aufi aufi commented May 16, 2023

Adding Indetity and Proxy resources to API tests. Identity provides samples with login/password, key and settings file.

Related to #268

Adding Indetity and Proxy resources to API tests. Identity provides
samples with login/password, key and settingss file.

Related to konveyor#268

Signed-off-by: Marek Aufart <[email protected]>
@aufi aufi changed the title Add Identity and Proxy to API tests. 🌱 Add Identity and Proxy to API tests. May 16, 2023

# Run Hub REST API tests.
test-api:
HUB_BASE_URL=${HUB_BASE_URL} go test -v ./test/api/...
HUB_BASE_URL=${HUB_BASE_URL} go test -count=1 -v ./test/api/...
Copy link
Member Author

@aufi aufi May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-count=1 disabled go test caching that is On by default and if code was not changed between test executions, tests are not executed, but result provided from cache (like PASS ok github.com/konveyor/tackle2-hub/test/api/identity (cached) ), this is not wanted e.g. in case tests execution can be affected with environment variables like HUB_BASE_URL or changes outside go files.

@aufi aufi requested a review from jortel May 16, 2023 16:10
Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aufi aufi merged commit 3bd44e4 into konveyor:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants