Work around FriBiDi include Makefile.third problem #1698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one potential solution to fixing the regression introduced by koreader#1679. I don't support this solution, nor its friend of adding a `touch $(FRIBIDI_DIR)/include` at the bottom. Including (hah!) most these `/include`s seems to be a mistake. They are to be generated by their relevant targets. Either they fail or they don't, simple, no weirdness. They're targets for the target!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one potential solution to fixing the regression introduced by #1679. I don't support this solution, nor its friend of adding a
touch $(FRIBIDI_DIR)/includeat the bottom.Including (hah!) most these
/includes seems to be a mistake. They are to be generated by their relevant targets. Either they fail or they don't, simple, no weirdness. They're targets for the target!--
Just as an fyi for archival purposes. Real PR in #1699.This change is