Resolution correction #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
640x512 is standard 50Hz PAL resolution however the demo appears to be running at 60Hz (480i) - I have corrected the resolution to be 640x448 as per standard 60Hz PS2 games (not 640x480, 640x448 for overscan compensation). This may free up a little more VRAM (40,000 less pixels after all) and probably yield marginally better performance?
|
Thank you so much for this PR and your recommandations (#18) ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
640x512 is standard 50Hz PAL resolution however the demo appears to be running at 60Hz (480i) - I have corrected the resolution to be 640x448 as per standard 60Hz PS2 games (not 640x480, 640x448 for overscan compensation). This may free up a little more VRAM (40,000 less pixels after all) and probably yield marginally better performance?