Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TeamController integration test #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hidayatrzayev
Copy link

This PR adds the integration test of the TeamController class.

Copy link

@arpan-banerjee7 arpan-banerjee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to use @RunWith(SpringRunner.class)? I checked it works without using it. But as far as I remember I had to put it or else spring would not recognize the annotations.

@hidayatrzayev
Copy link
Author

@arpan-banerjee7 I think this is necessary when using Junit 4, as far as the documentation is concerned:

When using JUnit 4, this annotation should be used in combination with @RunWith(SpringRunner.class).

https://docs.spring.io/spring-boot/docs/current/api/org/springframework/boot/test/autoconfigure/web/servlet/WebMvcTest.html

Since the test is written in Junit 5, it should be fine I guess.

@arpan-banerjee7
Copy link

@arpan-banerjee7 I think this is necessary when using Junit 4, as far as the documentation is concerned:

When using JUnit 4, this annotation should be used in combination with @RunWith(SpringRunner.class).

https://docs.spring.io/spring-boot/docs/current/api/org/springframework/boot/test/autoconfigure/web/servlet/WebMvcTest.html

Since the test is written in Junit 5, it should be fine I guess.

Okay !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants