Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use @generated as defined at https://generated.at #1770

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pjungermann
Copy link

Add the marker to "generated" at the file header
to make it easier for tooling to identify generated files as such.

Closes: #1604

Add the marker to "generated" at the file header
to make it easier for tooling to identify generated files as such.

Closes: koxudaxi#1604
Signed-off-by: Patrick Jungermann <[email protected]>
@koxudaxi
Copy link
Owner

@pjungermann
Thank you for creating the PR.
Do we need the breaking changes? I don't know if it is valuable (Probably a lot of project people will check the diffs)

What about providing this as a flag in the CLI?
It seems silly to add more options to the CLI, but I'm not too happy with the burden it would place on existing projects.

@pjungermann
Copy link
Author

@koxudaxi Personally, I would go for it and accept these one-time changes. However, I get your point, and not everyone might be interested in it.

I can look into a flag for the CLI. Of course, it might make the change much bigger, too. I assume you would like to keep the default to the previous behavior, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-generated top-level text must include the @generated word (with @ prepended).
2 participants