Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implements D-Adaptation optimizers #101

Merged
merged 86 commits into from
Feb 2, 2023
Merged

Conversation

kozistr
Copy link
Owner

@kozistr kozistr commented Feb 1, 2023

Problem (Why?)

new optimizers!

Solution (What/How?)

  • implement DAdaptAdaGrad optimizer
  • implement DAdaptAdam optimizer
  • implement DAdaptSGD optimizer
  • Shampoo Optimizer (related to Updated Shampoo uber slow performance #100)
    • supports no_preconditioning_for_layers_with_dim_gt
    • refactor matrix_power()
    • improve a speed of power_iter()

Other changes (bug fixes, small refactors)

  • docs for D-Adaptation optimizers
  • docs for Shampoo optimizer utils

Notes

bump version into v2.4.0

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (44c423a) to head (a3a5557).
Report is 1791 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   99.65%   99.69%   +0.03%     
==========================================
  Files          37       38       +1     
  Lines        2618     2940     +322     
==========================================
+ Hits         2609     2931     +322     
  Misses          9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozistr kozistr merged commit 75a023a into main Feb 2, 2023
@kozistr kozistr deleted the feature/d-adaptation branch February 2, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New features performance Performance size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants