Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change Lookahead's param_groups to a property #238

Merged
merged 2 commits into from
May 29, 2024
Merged

fix: change Lookahead's param_groups to a property #238

merged 2 commits into from
May 29, 2024

Conversation

michaldyczko
Copy link
Contributor

Problem (Why?)

#fixes #237

Solution (What/How?)

Changed param_groups attribute to a property.

@michaldyczko michaldyczko requested a review from kozistr as a code owner May 29, 2024 07:20
kozistr
kozistr previously approved these changes May 29, 2024
View reviewed changes
Copy link
Owner

@kozistr kozistr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! thanks for the fix :)

could you please run make format & make check?

@kozistr kozistr added the bug Something isn't working label May 29, 2024
@michaldyczko
Copy link
Contributor Author

great! thanks for the fix :)

could you please run make format & make check?

Done! :)

kozistr
kozistr approved these changes May 29, 2024
View reviewed changes
Copy link
Owner

@kozistr kozistr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems great! thanks for your contribution again

@kozistr kozistr merged commit 17893ed into kozistr:main May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozistr kozistr kozistr approved these changes

Assignees

@michaldyczko michaldyczko

Labels
bug Something isn't working size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lookahead`s param_groups attribute is not loaded from checkpoint.
2 participants
@michaldyczko @kozistr