Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reg_noise typing #240

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

michaldyczko
Copy link
Contributor

@michaldyczko michaldyczko commented May 29, 2024

Problem (Why?)

close #239

Solution (What/How?)

Replaced | with Union type.

@michaldyczko michaldyczko requested a review from kozistr as a code owner May 29, 2024 11:06
@kozistr kozistr added the bug Something isn't working label May 29, 2024
Copy link
Owner

@kozistr kozistr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution :)

@kozistr kozistr merged commit 7205a27 into kozistr:main May 29, 2024
2 checks passed
@kozistr kozistr assigned kozistr and michaldyczko and unassigned kozistr May 29, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (eda736f) to head (729a24e).
Report is 183 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           85        85           
  Lines         6416      6416           
=========================================
  Hits          6416      6416           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong typing of reg_noise
2 participants