-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Implement AdaLOMO
optimizer and others
#258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozistr
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
refactoring
Refactoring
dependencies
Dependencies
feature
New features
labels
Jul 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 90 90
Lines 6754 6863 +109
==========================================
+ Hits 6754 6863 +109 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Dependencies
documentation
Improvements or additions to documentation
enhancement
New feature or request
feature
New features
refactoring
Refactoring
size/XL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem (Why?)
lots of stuffs
Solution (What/How?)
AdaLOMO
optimizerQ-GaLore
optimizerbitbytesands
optimizersbitsandbytes
Other changes (bug fixes, small refactors)
AdaMini
optimizerget_rms
,approximate_sq_grad
functions toBaseOptimizer
for reusability.Notes
N/A