Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement AdaLOMO optimizer and others #258

Merged
merged 21 commits into from
Jul 14, 2024

Conversation

kozistr
Copy link
Owner

@kozistr kozistr commented Jul 14, 2024

Problem (Why?)

lots of stuffs

Solution (What/How?)

  • implement AdaLOMO optimizer
  • support Q-GaLore optimizer
  • support more bitbytesands optimizers
  • deprecate optional dependency, bitsandbytes

Other changes (bug fixes, small refactors)

  • refactor AdaMini optimizer
  • move get_rms, approximate_sq_grad functions to BaseOptimizer for reusability.

Notes

N/A

@kozistr kozistr added documentation Improvements or additions to documentation enhancement New feature or request refactoring Refactoring dependencies Dependencies feature New features labels Jul 14, 2024
@kozistr kozistr self-assigned this Jul 14, 2024
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (acd218b) to head (2acade3).
Report is 152 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #258    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           90        90            
  Lines         6754      6863   +109     
==========================================
+ Hits          6754      6863   +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozistr kozistr merged commit 3d4d440 into main Jul 14, 2024
4 checks passed
@kozistr kozistr deleted the feature/adalomo-optimizer branch July 14, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies documentation Improvements or additions to documentation enhancement New feature or request feature New features refactoring Refactoring size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant