🎮Implement the functionality to create and edit blog posts #39

OlenaYefymenko · 2024-03-28T22:29:35Z

This PR:

Adds new functions for the creation and edition of the posts;
Integrates the tests;
Provides updated templates and icons for the implementation of new functionality.

Link to task https://tutorial.djangogirls.org/en/django_forms/

Ref #18

codecov · 2024-03-29T11:59:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f6ccd09) to head (7afb54b).

Additional details and impacted files

@@            Coverage Diff             @@
##              main       #39    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           10        11     +1     
  Lines          118       222   +104     
  Branches         6         5     -1     
==========================================
+ Hits           118       222   +104

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blog/views.py

blog/templates/blog/base.html

blog/templates/registration/login.html

blog/urls.py

webknjaz · 2024-04-23T20:08:54Z

blog/templates/blog/base.html

-          <div class="container">
-              <h1><a href="/">Django Girls Blog</a></h1>
-          </div>
+            <div class="container">


Why did you change the indentation here?

What did you edit exactly and how?

I'm sorry I didn't understand what I should correct

Restore the original indentation, I suppose.

blog/forms.py

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>

OlenaYefymenko · 2024-05-01T15:53:40Z

@webknjaz in this PR a lot of non-informative commits, I'll do a squash in the last push.

OlenaYefymenko · 2024-07-03T20:48:49Z

django-girls-blog-OlenaEfymenko on  18-12-django-forms-new-edit via 🐍 3.11.2 using ☁️  default/fertu-pipeline-dev via django-girls-blog-OlenaEfymenko took 2.2s 
➜ python -m coverage run manage.py test      
Traceback (most recent call last):
  File "/home/olenayefymenko/django-girls-blog-OlenaEfymenko/manage.py", line 73, in <module>
    main()
  File "/home/olenayefymenko/.pyenv/versions/3.11.2/lib/python3.11/contextlib.py", line 81, in inner
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "/home/olenayefymenko/django-girls-blog-OlenaEfymenko/manage.py", line 69, in main
    execute_from_command_line(sys.argv)
  File "/home/olenayefymenko/django-girls-blog-OlenaEfymenko/.venv/lib/python3.11/site-packages/django/core/management/__init__.py", line 442, in execute_from_command_line
    utility.execute()
  File "/home/olenayefymenko/django-girls-blog-OlenaEfymenko/.venv/lib/python3.11/site-packages/django/core/management/__init__.py", line 436, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/olenayefymenko/django-girls-blog-OlenaEfymenko/.venv/lib/python3.11/site-packages/django/core/management/__init__.py", line 275, in fetch_command
    klass = load_command_class(app_name, subcommand)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/olenayefymenko/django-girls-blog-OlenaEfymenko/.venv/lib/python3.11/site-packages/django/core/management/__init__.py", line 48, in load_command_class
    module = import_module("%s.management.commands.%s" % (app_name, name))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/olenayefymenko/.pyenv/versions/3.11.2/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1206, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1178, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1149, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/olenayefymenko/django-girls-blog-OlenaEfymenko/.venv/lib/python3.11/site-packages/django/core/management/commands/test.py", line 6, in <module>
    from django.test.runner import get_max_test_processes
  File "/home/olenayefymenko/django-girls-blog-OlenaEfymenko/.venv/lib/python3.11/site-packages/django/test/__init__.py", line 3, in <module>
    from django.test.client import AsyncClient, AsyncRequestFactory, Client, RequestFactory
  File "/home/olenayefymenko/django-girls-blog-OlenaEfymenko/.venv/lib/python3.11/site-packages/django/test/client.py", line 727
    session = await self.asession()
              ^^^^^^^^^^^^^^^^^^^^^
SyntaxError: 'await' outside async function
/home/olenayefymenko/django-girls-blog-OlenaEfymenko/.venv/lib/python3.11/site-packages/coverage/inorout.py:519: CoverageWarning: Module blog was previously imported, but not measured (module-not-measured)
  self.warn(msg, slug="module-not-measured")
/home/olenayefymenko/django-girls-blog-OlenaEfymenko/.venv/lib/python3.11/site-packages/coverage/inorout.py:519: CoverageWarning: Module mysite was previously imported, but not measured (module-not-measured)
  self.warn(msg, slug="module-not-measured")
/home/olenayefymenko/django-girls-blog-OlenaEfymenko/.venv/lib/python3.11/site-packages/coverage/control.py:887: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")

blog/forms.py

mysite/urls.py

tests/test_views.py

OlenaYefymenko · 2024-07-03T22:59:23Z

@webknjaz thank you for review, I'll change and push

Edit tests

This patch provides property tests after the last review and includes additional logic for user login and logout. Tests

webknjaz · 2024-12-09T17:16:14Z

blog/templates/blog/base.html

        </header>
-        <main class="container">
+        <main class="content container">


How does this relate to editing the posts?

webknjaz · 2024-12-09T17:17:08Z

requirements/dev.txt

Perhaps perform package version bumps in a separate PR?

webknjaz · 2024-12-09T17:21:50Z

tests/test_views.py

+                kwargs={'pk': new_post.pk},
+            ),
+        )
+        self.assertEqual(new_post.title, 'Test Title')


It's a bit difficult to connect the dots when this constant string is defined here, but the data it compares to is defined elsewhere. Why not reuse the same value saved into a var?

webknjaz · 2024-12-09T17:33:05Z

tests/test_views.py

+        self.assertContains(
+            http_response, 'This field is required.', html=True,
+        )


Try using the assertFormError() helper:

https://docs.djangoproject.com/en/5.1/topics/testing/tools/#django.test.SimpleTestCase.assertFormError

https://developer.mozilla.org/en-US/docs/Learn/Server-side/Django/Testing#testing_views_with_forms

https://gist.github.com/cwurld/f132f673446158808952#file-django_testcase_cheatsheet-py-L80

webknjaz · 2024-12-09T17:38:21Z

tests/test_views.py

+        self.assertEqual(post.title, 'Updated Title')
+        self.assertEqual(post.text, 'Updated Text')
+        self.assertEqual(post.author, self.user)
+        self.assertNotEqual(post.published_date, initial_published_date)


While this is a useful check, the best way of dealing with the time changes is freezing it. There are libraries like freezegun and similar that monkey-patch the stdlib that could be used. But since you did it manually in the past already, I suggest repeating the same technique here: https://github.com/kpi-web-guild/django-girls-blog-OlenaEfymenko/blob/f6ccd09/tests/test_views.py#L60-L63.

webknjaz · 2024-12-09T17:42:43Z

tests/test_views.py

+        self.assertNotEqual(post.published_date, initial_published_date)
+
+    def test_post_edit_invalid_form_authorized(self):
+        """Test handling of invalid form submission when editing a post."""


It's best to avoid using the vague "test doing something generic and abstract" and focus on declaring the expectation. The outcome of this test is probably not that you executed a test for the sake of executing a test that mentions handling the form. Instead, you probably expect that using a form in a specific way would result in a specific reaction of the server, don't you? Why not mention that specific thing in the docstring?

OlenaYefymenko requested a review from webknjaz March 28, 2024 22:53

OlenaYefymenko self-assigned this Mar 28, 2024

OlenaYefymenko added the enhancement New feature or request label Mar 28, 2024

webknjaz reviewed Apr 1, 2024

View reviewed changes

blog/views.py Outdated Show resolved Hide resolved

OlenaYefymenko added 9 commits April 23, 2024 14:27

Integrate the new functionality for the creation new posts

d8c57c8

Integrate the function to implement the edition of the posts

5622865

Add user authentication check for post creation and editing

4013952

Add tests for the new function providing the creation of new posts

ab9480f

Implement user authentication, it will be squash to the previous commit

5db7fcb

Edit typo in post_new function

5379f30

Delete the redundant check in the test

7948227

Add additional test checks for block else in the post_new function

781c37c

Add draft tests

007f604

OlenaYefymenko force-pushed the 18-12-django-forms-new-edit branch from d561880 to 007f604 Compare April 23, 2024 17:52

webknjaz reviewed Apr 23, 2024

View reviewed changes

blog/templates/blog/base.html Outdated Show resolved Hide resolved

webknjaz reviewed Apr 23, 2024

View reviewed changes

blog/templates/registration/login.html Outdated Show resolved Hide resolved

webknjaz reviewed Apr 23, 2024

View reviewed changes

blog/urls.py Outdated Show resolved Hide resolved

webknjaz reviewed Apr 23, 2024

View reviewed changes

blog/forms.py Outdated Show resolved Hide resolved

OlenaYefymenko and others added 3 commits April 27, 2024 23:30

Update blog/templates/registration/login.html

ea579c8

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>

Update blog/urls.py

9d05e29

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>

Update blog/forms.py

a0c0b52

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>

webknjaz reviewed Jul 3, 2024

View reviewed changes

blog/forms.py Outdated Show resolved Hide resolved

webknjaz reviewed Jul 3, 2024

View reviewed changes

mysite/urls.py Outdated Show resolved Hide resolved

webknjaz reviewed Jul 3, 2024

View reviewed changes

tests/test_views.py Outdated Show resolved Hide resolved

webknjaz reviewed Jul 3, 2024

View reviewed changes

tests/test_views.py Outdated Show resolved Hide resolved

OlenaYefymenko marked this pull request as ready for review July 3, 2024 22:56

OlenaYefymenko added 5 commits December 9, 2024 01:24

Correct base httm template

f867a8b

Edit the tests

907e222

Edit tests

Add the docstrings

77694a0

Edit the tests and templates

b4724e7

This patch provides property tests after the last review and includes additional logic for user login and logout. Tests

Update dependencies to fix test runner async error

938264b

OlenaYefymenko force-pushed the 18-12-django-forms-new-edit branch from 54f3d36 to 938264b Compare December 9, 2024 00:18

Delete the extra line

7afb54b

OlenaYefymenko requested a review from webknjaz December 9, 2024 00:34

webknjaz reviewed Dec 9, 2024

View reviewed changes

requirements/dev.txt

Copy link

Member

webknjaz Dec 9, 2024 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps perform package version bumps in a separate PR?

webknjaz reviewed Dec 9, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎮Implement the functionality to create and edit blog posts #39

🎮Implement the functionality to create and edit blog posts #39

OlenaYefymenko commented Mar 28, 2024

codecov bot commented Mar 29, 2024 •

edited

Loading

webknjaz Apr 23, 2024

OlenaYefymenko May 1, 2024

webknjaz Jul 3, 2024

OlenaYefymenko Dec 9, 2024

webknjaz Dec 9, 2024 •

edited

Loading

OlenaYefymenko commented May 1, 2024

OlenaYefymenko commented Jul 3, 2024 •

edited by webknjaz

Loading

OlenaYefymenko commented Jul 3, 2024

webknjaz Dec 9, 2024

webknjaz Dec 9, 2024 •

edited

Loading

webknjaz Dec 9, 2024

webknjaz Dec 9, 2024

webknjaz Dec 9, 2024

webknjaz Dec 9, 2024

🎮Implement the functionality to create and edit blog posts #39

Are you sure you want to change the base?

🎮Implement the functionality to create and edit blog posts #39

Conversation

OlenaYefymenko commented Mar 28, 2024

codecov bot commented Mar 29, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webknjaz Dec 9, 2024 • edited Loading

Choose a reason for hiding this comment

OlenaYefymenko commented May 1, 2024

OlenaYefymenko commented Jul 3, 2024 • edited by webknjaz Loading

OlenaYefymenko commented Jul 3, 2024

Choose a reason for hiding this comment

webknjaz Dec 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Mar 29, 2024 •

edited

Loading

webknjaz Dec 9, 2024 •

edited

Loading

OlenaYefymenko commented Jul 3, 2024 •

edited by webknjaz

Loading

webknjaz Dec 9, 2024 •

edited

Loading