Configure files and settings for heroku deployment #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RootenberG
force-pushed
the
feature/add-settings-for-heroku-deployment
branch
6 times, most recently
from
4c647d6 to
fabb51b
Compare
webknjaz
requested changes
Sep 22, 2019
requirements.txt
Outdated
| @@ -1 +1,5 @@ | |||
| dj-database-url==0.5.0 | |||
requirements.txt
Outdated
| Django~=2.2.2 | ||
| gunicorn==19.9.0 | ||
| psycopg2==2.8.3 |
requirements.txt
Outdated
| Django~=2.2.2 | ||
| gunicorn==19.9.0 | ||
| psycopg2==2.8.3 | ||
| whitenoise==4.1.3 |
| Django~=2.2.2 | ||
| gunicorn==19.9.0 |
There was a problem hiding this comment.
This is the only dependency that is related to configuring a web service run command in Heroku.
RootenberG
force-pushed
the
feature/add-settings-for-heroku-deployment
branch
from
fabb51b to
d0bf531
Compare
webknjaz
reviewed
Sep 26, 2019
mysite/settings.py
Outdated
| @@ -115,3 +116,7 @@ | |||
| STATIC_URL = '/static/' | |||
|
|
|||
| STATIC_ROOT = os.path.join(BASE_DIR, 'static') | |||
|
|
|||
| STATICFILES_DIRS = ( | |||
There was a problem hiding this comment.
I don't understand why you did this. Also, why didn't you just assign what already exists?
Suggested change
| STATICFILES_DIRS = ( | |
| STATICFILES_DIRS = STATIC_ROOT |
There was a problem hiding this comment.
I dropped unrelated commits.
RootenberG
force-pushed
the
feature/add-settings-for-heroku-deployment
branch
from
b42cf58 to
342e6df
Compare
webknjaz
reviewed
Oct 2, 2019
webknjaz
requested changes
Oct 2, 2019
RootenberG
force-pushed
the
feature/add-settings-for-heroku-deployment
branch
2 times, most recently
from
8a9d402 to
7f217f9
Compare
RootenberG
changed the title
RootenberG
changed the title
RootenberG
force-pushed
the
feature/add-settings-for-heroku-deployment
branch
from
7f217f9 to
c416dfa
Compare
|
Your commit messages just repeat obvious commit contents, describing the
implementation details while they should describe high-level commit
purposes instead.
чт, 24 жовт. 2019 о 11:59 Denis <[email protected]> пише:
… @webknjaz <https://github.com/webknjaz> What's wrong with my commits?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26?email_source=notifications&email_token=AAENH37VK36T2JZUQG2WME3QQFWZNA5CNFSM4IY766B2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECEOY3I#issuecomment-545844333>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAENH37B7HXYDXYQOURWBP3QQFWZNANCNFSM4IY766BQ>
.
--
Kind regards,
Sviatoslav Sydorenko
email: [email protected]
cell #: +380978963757
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20