Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPT: updated code to Pydantic 2.0 (get rid of deprecation warnings) #98

Merged
merged 4 commits into from
Feb 2, 2024
Merged

OPT: updated code to Pydantic 2.0 (get rid of deprecation warnings) #98

merged 4 commits into from
Feb 2, 2024

Conversation

wpeterw
Copy link
Contributor

@wpeterw wpeterw commented Jan 9, 2024

  • use Pydantic 2.x syntax

@wpeterw wpeterw requested a review from eigenein as a code owner January 9, 2024 17:10
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0de195) 91.84% compared to head (e10c9ea) 91.87%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   91.84%   91.87%   +0.03%     
==========================================
  Files          35       35              
  Lines         785      788       +3     
  Branches       87       87              
==========================================
+ Hits          721      724       +3     
  Misses         47       47              
  Partials       17       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eigenein eigenein added the enhancement New feature or request label Jan 10, 2024
eigenein
eigenein requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@eigenein eigenein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wpeterw,

Thanks for the changes! Two things:

  • The # type: ignore are not needed any more, hence the failed linter checks
  • I believe we should restrict Pydantic to >=2.0.0 now because 1.x requires the conint annotation

@wpeterw wpeterw force-pushed the fix/pydantic_deprecation_warnings branch from 18dcc93 to a7f878c Compare January 13, 2024 15:39
@eigenein
Copy link
Member

@wpeterw Can we merge this?

@eigenein eigenein changed the title refactor: Updated code to Pydantic 2.0 (get rid of deprecation warnings) OPT: updated code to Pydantic 2.0 (get rid of deprecation warnings) Feb 2, 2024
@eigenein eigenein merged commit dcdf297 into kpn:main Feb 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eigenein eigenein eigenein approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpeterw @eigenein