Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: race condition when creating metrics at the same time that a str… #121

Conversation

marcosschroh
Copy link
Collaborator

…eam is removed

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #121 (f76be2c) into master (bab1531) will decrease coverage by 0.26%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   94.32%   94.06%   -0.26%     
==========================================
  Files          20       20              
  Lines         705      708       +3     
==========================================
+ Hits          665      666       +1     
- Misses         40       42       +2     
Flag Coverage Δ
unittests 94.06% <60.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
kstreams/prometheus/monitor.py 97.91% <50.00%> (-2.09%) ⬇️
kstreams/engine.py 97.97% <100.00%> (ø)

@marcosschroh marcosschroh merged commit e5e94a9 into kpn:master Jul 25, 2023
4 of 7 checks passed
@marcosschroh marcosschroh deleted the fix/race-condition-on-metrics-and-remove-stream branch July 25, 2023 11:40
marcosschroh added a commit that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants