Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase total events also when using sync testing #136

Conversation

marcosschroh
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (28a377d) 94.10% compared to head (85c2d8f) 95.91%.
Report is 12 commits behind head on master.

Files Patch % Lines
kstreams/test_utils/topics.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   94.10%   95.91%   +1.81%     
==========================================
  Files          20       20              
  Lines         712      735      +23     
==========================================
+ Hits          670      705      +35     
+ Misses         42       30      -12     
Flag Coverage Δ
unittests 95.91% <66.66%> (+1.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosschroh marcosschroh force-pushed the fix/increse-total-events-when-use-sync-testing branch from be6ead1 to b756cca Compare November 22, 2023 14:12
@marcosschroh marcosschroh force-pushed the fix/increse-total-events-when-use-sync-testing branch from b756cca to 85c2d8f Compare November 22, 2023 14:13
@marcosschroh marcosschroh merged commit 45c4473 into kpn:master Nov 22, 2023
5 of 7 checks passed
@marcosschroh marcosschroh deleted the fix/increse-total-events-when-use-sync-testing branch November 22, 2023 14:54
marcosschroh added a commit to marcosschroh/kstreams that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants