Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for OpenAPI 3.0 #183

Merged
merged 3 commits into from
Aug 4, 2020
Merged

Conversation

sprootshift
Copy link
Contributor

This pull request adds initial support for OpenAPI 3.0.

enjoi dependency is a placeholder to be updated later if/when tlivings/enjoi#92 is merged.

@tlivings
Copy link
Contributor

Also have #183 PR...

@sprootshift
Copy link
Contributor Author

My understanding is that #181 is a very different approach. It is more of a refactoring of the library to abstract away the details of Swagger and OpenAPI3 schema into a single proxy object. I am not sure how much of it is really needed, given that swagger-parser does a decent job parsing both. In my approach I am working directly with swagger-parser output and it seems to work reasonably well. But if you think there is value in the intermediate proxy representation of swagger-parser output, I think it can be merged into this PR.

@sprootshift
Copy link
Contributor Author

@tlivings So what's your view of these PRs? Is it something you consider to merge?

@tlivings
Copy link
Contributor

I am trying to get to this today. Been slammed and distracted by day job.

@tlivings tlivings merged commit cc09e61 into krakenjs:master Aug 4, 2020
@sprootshift
Copy link
Contributor Author

Thanks for merging it. Could you please publish enjoi first and then this, after I update dependency to npm enjoi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants