Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TargetJ to js-framework-benchmark #1809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wasfi2
Copy link

@wasfi2 wasfi2 commented Dec 20, 2024

This requests adds the TargetJ framework to the js-framework-benchmark repository.

Key changes:
index.html: contains the main HTML structure
src/main.js: implements benchmark functionality using TargetJ.
src/data.js: creates the data sample
package.json and package-lock.json: define the dependencies

@wasfi2
Copy link
Author

wasfi2 commented Dec 21, 2024

TargetJ is available at https://github.com/livetrails/targetj. Feel free to reach out if you need more information.

@krausest
Copy link
Owner

krausest commented Dec 27, 2024

Thanks. To conform with the keyed implementations the swap operation must actually swap the corresponding dom nodes. It can be invoked in the webdriver-ts folder with the following command:

npm run isKeyed keyed/targetj

It prints the following error:

Keyed test for swap failed. Expected at least 1 added and 1 removed TR, but there were 0 added and 0 removed
targetj-v1.0.118-keyed is keyed for 'run benchmark' and keyed for 'remove row benchmark' and non-keyed for 'swap rows benchmark' . It'll appear as non-keyed in the results

Can you take a look at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants