Add state argument to delete #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanLorimer
force-pushed
the
add-state-argument-to-delete
branch
from
fd72f41
to
71c8f31
Compare
|
@krdlab I rebased, and fixed the failure on the example component. Ready for review again |
krdlab
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also includes diff changes from #65
All call sites of
sessionStoreDeletehave access to the state argument, and in my case I want to only clear the state for a specific authentication request (not all of them), therefore I need to identify which entry I am going to remove.I could parameterize my entire session store by
Statebut that is kind of clunky and doesn't allow me to simply define the session store once.