-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-sync for upstream #3
Open
cdenneen
wants to merge
135
commits into
kreczko:kreczko-issue-419
Choose a base branch
from
cdenneen:kreczko-issue-419
base: kreczko-issue-419
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octokit outputs warning message for preview API such as `issue_events`, which is annoying. We can explicitly add the accept option when calling the API to disable it. Refer to `lib/octokit/preview.rb` in octokit for more information. fix: github-changelog-generator#773
…og-generator/missing-bin Put back bin files
- this updates the .ruby-version file which some ruby version managers use - this updates the Gemfile.lock, so that users do not get a diff when they use the latest version of Ruby
Bumps [backports](https://github.com/marcandre/backports) from 3.17.0 to 3.17.1. - [Release notes](https://github.com/marcandre/backports/releases) - [Changelog](https://github.com/marcandre/backports/blob/master/CHANGELOG.md) - [Commits](marcandre/backports@v3.17.0...v3.17.1) Signed-off-by: dependabot-preview[bot] <[email protected]>
- this raises the required_ruby_version to 2.5
…Generator::Helper
…b-changelog-generator into kreczko-issue-419 * 'kreczko-issue-419' of https://github.com/cdenneen/github-changelog-generator: (26 commits) Add gitlab to rake task resolved second batch of feedback from @olleolleolle Last few Github -> Gitlab conversions added gitlab_changelog_generator preliminary tests for gitlab_fetcher fixed RuboCop issues for gitlab_fetcher CHANGELOG_GITHUB_TOKEN --> CHANGELOG_AUTH_TOKEN for gitlab fetcher missing change from Github->Gitlab change: Helper --> GitHubChangelogGenerator::Helper added Gitlab URI example Github --> Gitlab for GitlabFetcher fixed if-logic based on feedback from olleolleolle fix gitlab fetcher for project that have no issues separated fetching issues and pull requests as it was causing problems at times fixed merge_commit_sha for older gitlab versions in gitlab_fetcher fixed events for merge requests in gitlab_fetcher fixed project_id for gitlab_fetcher in the case of forks fixed issues and associated events in gitlab_fetcher fixed typo in generator_fetcher fixed authors in merge_requests for gitlab fetcher restricting gitlab fetcher to closed issues ...
…variable: CHANGELOG_GITHUB_TOKEN
@kreczko I also updated the TOKEN from the AUTH one you had to match the upstream one so there is only one variable regardless if your using GITHUB or GITLAB. Are you okay with this or do you want me to revert this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and applied rubocop changes necessary for merging upstream