Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: #28 long time to load bg image #34

Closed
wants to merge 7 commits into from
Closed

enhance: #28 long time to load bg image #34

wants to merge 7 commits into from

Conversation

jjinendra3
Copy link
Contributor

Summary

Changed the jpeg bg image to webp file eliminating 5-6 seconds and crucial resources that was being taken to load a bg image.

Description

Hosted the converted jpeg to webp file on imgbb to save on the overall build site keeping in mind that we will never the chanage the bg image, the home page now loads much faster and looks better.

Images

OLD AND NEW GIFS

Issue(s) Addressed

Enter the issue number of the bug(s) that this PR fixes

Review Checklist

Please make sure to go through this checklist before submitting your review.

  • [ x] Make sure the PR title is of format tag: Issue Title
    • tag should be one of fix,feat, docs, chore, refactor
    • Ex: feat: Added responsive design for the home page
  • [ x] Ensure the code follows our coding standards and guidelines
    • Ex: naming conventions should be of form file-name.ts not fileName.ts
  • [ x] Ensure that you have staged only the required commits and raised the PR and not included all the files which would be otherwise required for local setup
  • [ x] Check if the PR is rebased to the latest main/development branch.
  • [ x] Make sure there are no unnecessary files or debugging artifacts in the PR.

@vercel
Copy link

vercel bot commented Oct 31, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @krishnaacharyaa on Vercel.

@krishnaacharyaa first needs to authorize it.

@jjinendra3
Copy link
Contributor Author

Hey @krishnaacharyaa ,tried to create a new pr following the given pr template, and for the previous commits , im a little new at git for now, i have tried my best to do as you mentioned but if it is still not as it should be, please inform me for the same ill try to do more research about it and create a new pr..... Thanks, any kind of feedback will be greatly appreciated

@krishnaacharyaa
Copy link
Owner

Thank you @jjinendra3, for your sincere efforts I really appreciate the time and efforts put into storing the gif into google drive and sharing the link, which was not expected, thank you for the efforts.

Just some points to share if you already didn't know,

Some observations

  • Why does it say it closes 1st issue ?
  • And small spacing issues in the [ x] it should have been [x]

@krishnaacharyaa
Copy link
Owner

krishnaacharyaa commented Oct 31, 2023

To answer the git part
I have tried to explain the present scenario to the best according to my understanding about git, please feel free to go through you might have to do some research on top of it, I have just tried to give you overall understanding, hope it helps.
If there is still more questions to ask, we can have a call.
Please go through and if you further find nice articles about git feel free to share, there's always more things to learn :)

image

@krishnaacharyaa
Copy link
Owner

Just one thing to keep in mind you can use this as reference dont take my word for it, sometimes some part even I might have missed, feel free to let me know if any. Happy to correct myself and learn :)
And you might have to close this PR and raise new PR for this as per my understanding, feel free to explore what is the best solution :) You know what I would do now :)

@jjinendra3
Copy link
Contributor Author

Hey @krishnaacharyaa ,

I wanted to take a moment to express my sincere thanks your efforts that have helped me grow and learn, not only about Git/GitHub but also about the MERN stack.

The guidance and knowledge you've shared is something I genuinely appreciate.

Now, I plan to create a new pull request and will try incorporate all the changes you've mentioned.

Thank you once again for your guidance and the opportunity to contribute to this project.

@jjinendra3 jjinendra3 closed this Oct 31, 2023
@krishnaacharyaa
Copy link
Owner

@jjinendra3 Thank you for your kind words 😇 Always happy to share and I am glad to hear that it is greatly helping you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the homepage bg image long load time Centralised Error Handling
2 participants