fix-#445: Absence of a Proper Loading skeleton for the AddBlog Section #pr446 #451
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @MetiUmashri! Thanks for sticking to the guidelines! High five! 🙌🏻 |
|
@krishnaacharyaa i have made the changes |
|
Please add snapshots of both the loaders |
|
Hey @MetiUmashri! Thanks for sticking to the guidelines! High five! 🙌🏻 |
|
i have added the screenshots, in the below screenshot of the loader working the footer is also seen, my screenshot is unable to capture it. But in both the loaders the footer is seen. @krishnaacharyaa i have added the screenshots. |
|
|
||
| function RequireAuth({ allowedRole }: { allowedRole: string[] }) { | ||
| const { role, token, loading } = useAuthData(); | ||
|
|
||
| if (loading) { | ||
| return ( | ||
| <> | ||
| <Loader /> | ||
| <Loader/> | ||
| </> |
There was a problem hiding this comment.
Which is this loader? Can you paste the screenshot of this?
There was a problem hiding this comment.
Can you enhance this even? For other cases let's say full page circular loader with white and black theme?
There was a problem hiding this comment.
If you prefer a new PR for that, i'm fine with that, just let me know
|
Hey sorry yaar @MetiUmashri , i thought i had commented, figured out i hadn't published it was in pending state, sorry for that, a bit busy with workplace, excuse me for the delay |
|
Hey @krishnaacharyaa @MetiUmashri and I thought of improving the next loader in a different PR 😁 |
Summary
This PR provides a Loading Skeleton for the AddBlog section so that the user has a seamless experience
Description
AddBlogPostSkeleton Component has been added and has been used to replace the previous Loader component that was used.
Images
Issue(s) Addressed
Closes #445
Enter the issue number of the bug(s) that this PR fixes
Template should be strictly Closes <issue_number>
Example: Closes Centralised Error Handling #1
Prerequisites