Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #66 : select upto only 3 categories #78

Merged
merged 8 commits into from
Dec 14, 2023

Conversation

vivek6201
Copy link
Contributor

@vivek6201 vivek6201 commented Dec 12, 2023

Summary

To issue user should not add more than 3 categories.

Description

I have resolved the bug by checking the length of the categories array and stoped the user to add more category after the limit is reached, css is also added so that user can know that more category cannot be added.

Issue(s) Addressed

Closes #66

Prerequisites

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 1:55pm
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 1:55pm

@krishnaacharyaa
Copy link
Owner

Thank you for the PR, unfortunately this doesn't bind to our conversation while assigning the issue, kindly follow that, that is the acceptance criteria for this issue.
For ref: #66 (comment)

FYI: reason because of which the build is failing
image

@vivek6201
Copy link
Contributor Author

@krishnaacharyaa hey all checks have been passed, please check the code as i have the addressed the suggestions given in the comment of issue #73

@krishnaacharyaa
Copy link
Owner

@vivek6201, there seems to be some communication gap,

Sure @vivek6201, It's almost done in #73, just try to resolve the comments, that would suffice.

As mentioned here, the task is to simply complete #73 (comment), and the rest of the implementation to be followed from #73,
(It is linked to another story, and then we had aggreed upon the implementation, so kindly follow the same approach)

@vivek6201
Copy link
Contributor Author

hey @krishnaacharyaa , changes have been made according to comments please check

Copy link
Owner

@krishnaacharyaa krishnaacharyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly follow the comment highlighted more than twice for now, take your time understand what is the requirement and come up with a solution, too much time is exhausted mutually explaining thing recursively.

frontend/src/components/category-pill.tsx Show resolved Hide resolved
frontend/src/pages/add-blog.tsx Show resolved Hide resolved
frontend/src/pages/add-blog.tsx Show resolved Hide resolved
@krishnaacharyaa
Copy link
Owner

krishnaacharyaa commented Dec 14, 2023

You should just solve the comment #73, nothing plus nor minus, you tried doing everything except the thing requested...

Just implement #73 (comment)

@krishnaacharyaa krishnaacharyaa marked this pull request as draft December 14, 2023 11:33
@vivek6201
Copy link
Contributor Author

sorry, as this is taking more than the desired time according to the issue. but, this code shold work now. @krishnaacharyaa, i request to check for the last time.

@vivek6201 vivek6201 marked this pull request as ready for review December 14, 2023 13:54
Copy link
Owner

@krishnaacharyaa krishnaacharyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix, looks good now, merging this.

p.s: kindly take care of the commit messages next time, the commit messages helps in the nice structuring of the code

frontend/src/pages/add-blog.tsx Show resolved Hide resolved
@krishnaacharyaa krishnaacharyaa merged commit 439d88a into krishnaacharyaa:main Dec 14, 2023
3 checks passed
@vivek6201 vivek6201 deleted the add-blog-issue branch December 15, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Disable other options if three categories are selected while creating a post
2 participants